Conversation
scranford1
force-pushed
the
feature/edr-compliance
branch
from
6d1d911 to
6bc4887
Compare
jdw-creare
left a comment
jdw-creare
left a comment
There was a problem hiding this comment.
This looks good to me, thanks Sam!
| "temporal": { | ||
| "interval": [iso_times[0], iso_times[-1]] if len(iso_times) > 0 else [], | ||
| "values": iso_times, | ||
| "trs": trs, |
There was a problem hiding this comment.
Does this need a default value in case someone passes in None? I think json.dumps() will serialize None as null, which might be what EDR expects anyway.
I got here by wondering if the line reading trs = collection_configuration[dataset]["extents"]["temporal"].get("trs") needs a default on the get() call, which would be another place to provide a default if that makes more sense.
There was a problem hiding this comment.
The standard specifies 'trs' as a required string. So I think any empty string or null is probably non-compliant. In our case, the collection_configuration trs should always exist. I could copy the configuration value to also be the default, but to me that seemed like doubling up.
|
Let me know if you want to make any of those optional changes, otherwise feel free to merge or let me know and I'll merge. |
Thanks @jdw-creare, I will look through these and address them! (I will plan on merging it in once I am done). |
|
2 participants
Improvements to the EDR endpoints to get closer to V1.1.0 Standard Compliance. The conformance will still be stated as 1.0.1 until we deem it time to change over.